uazo / cromite

Cromite a Bromite fork with ad blocking and privacy enhancements; take back your browser!
https://www.cromite.org/
GNU General Public License v3.0
2.9k stars 63 forks source link

Youtube and google sites not following dark system theme #383

Open shadowsangel0696 opened 9 months ago

shadowsangel0696 commented 9 months ago

Preliminary checklist

Can the bug be reproduced with corresponding Chromium version?

Yes

Cromite version

117.0.5938.153

Device architecture

windows

Platform version

Windows 11

Android Device model

Windows PC

Is the device rooted?

I prefer not to write it

Changed flags

no flags changed

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

No.

Describe the bug

When i switch to dark theme every website switches to dark mode but youtube and other google sites keep staying in light theme. Tried disabling adblock and flags but nothing changed.

Steps to reproduce the bug

1 all sites are on light mode. 2 when windows switches to dark theme every website goes dark except youtube and some other google sites. If i close and reopen the browser youtube is dark but after some minutes if i refresh the page returns again with the light theme.

Expected behavior

Youtube and google sites following dark system theme.

Screenshots

No response

uazo commented 9 months ago

yes, I realised that too, but in android. but I don't know if it's good or bad, in the sense that if I confuse the site on user choice it's good, if it's a bug it's bad. i have to check.

shadowsangel0696 commented 9 months ago

hello the bug of google sites dark theme has been fixed with the new update?

foxjaw commented 7 months ago

not convinced, it remains a way of fingerprinting the device.

Fingerprinting is I think a very broad issue. There are a lot of data points acquirable when JavaScript enabled. And a few data points without javascript. #581 will probably won't affect fingerprinting tactics followed by phishy sites in any way. It's the JS & other technologies which are insecure & succeptable to fingerprinting. Google webpages I donno about them. But they aren't the only holy grail that exist on the Internet. Many sites already adapt webview dark config of the browser very well.

If the site has it's own dark mode, it uses that & webview ignores inversion. And if not, webview will inverse it based on ceilab based image selective inversion.

uazo commented 7 months ago

And a few data points without javascript It's the JS & other technologies which are insecure & succeptable to fingerprinting.

let's discuss it if you, not in this issue, is not quite what you say. or rather, fingerprinting and tracking cannot be decoupled. making fingerprinting less possible by deactivating js increases the possibility of tracking and also in a simple manner with css. I would not deactivate js, but let's not talk about it here.

foxjaw commented 7 months ago

Sure. But remember that I didn't bought up the fingerprint discussion btw. Bad websites WILL always try to track/fingerprint in whatever way possible. That we can't escape from. But that doesn't mean that Dark Mode amplifies it more. A lot of users enable dark mode, so sites fingerprinting you & identifying you would be a 50/50 chance, depending on how many are on light mode or dark mode.

Btw, bromite had patches to mitigate this, so need to worry implementing per-site dark mode.

uazo commented 7 months ago

Btw, bromite had patches to mitigate this, so need to worry implementing per-site dark mode.

?? cromite is derived from bromite, and no, it has no patch to mitigate it.

foxjaw commented 7 months ago

You mean google sites issue ? No. I meant fingerprinting mitigations. Btw tracking this issue ain't useful to me. Not sure why you closed #581 & lead me to here, but okay.
On other webview based browsers like privacy browser, per-site dark mode works without any issues.