Check Vivaldi source code

[uazo]

Check how vivaldi works:

Actually:

• chromium version: 118.0.5993.122
• vivaldi version: 6.4.3160 https://source.vivaldi.com/vivaldi-source_6.4.3160.tar.xz

if possible, check whether it is possible to automate the process for https://github.com/uazo/superpatch as done for kiwi and brave

[PF4Public]

What interesting do you expect to find there?

[uazo]

buth, I don't know, I'm hoping for something to simplify the rebase or some feauture to draw inspiration from. Lately I have little time (it is always like that in the last quarter of the year because of my job) but many ideas, I am trying to put them in writing, maybe I will find someone eager to help :)

[uazo]

well, something interesting I have already found:

• https://github.com/ric2b/Vivaldi-browser/blob/master/chromium/base/android/java/src/org/chromium/base/metrics/RecordUserAction.java#L30 https://github.com/ric2b/Vivaldi-browser/blob/master/chromium/base/metrics/user_metrics.cc#L45 blocks user action management (see chrome://user-actions)
• https://github.com/ric2b/Vivaldi-browser/blob/master/chromium/base/feature_list.cc#L387 <-- check whether it is really needed
• check what is org.vivaldi.browser.screen_lock.ScreenLock org.vivaldi.browser.anr_watchdog.ANRWatchDog
• check what VivaldiPreferences.SWIPE_TO_CLOSE_TAB VivaldiPreferences.ENABLE_TAB_STACK VivaldiPreferences.FOCUS_ADDRESS_BAR_ON_NEW_TAB is for
• Also interesting is the logic whereby they do not delete code but insert anif (ChromeApplicationImpl.isVivaldi()) return; there is also a c++ counterpart.
• with the bottom bar, they tidy up the layout at the start https://github.com/ric2b/Vivaldi-browser/blob/master/chromium/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerImpl.java#L343, whereas I do it differently, theirs is nicer.
• ChromeContextMenuItem.OPEN_IN_NEW_TAB_BACKGROUND I begin to understand some of the requests of users, they compare features already existing in other browsers
• IncognitoNotificationManager for the always incognito
• check https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/src/org/chromium/chrome/browser/usage_stats/features.gni;bpv=1;bpt=0
• External downloader https://github.com/ric2b/Vivaldi-browser/blob/master/chromium/chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/DownloadDialogBridge.java#L232
• ENABLE_HANGOUT_SERVICES_EXTENSION gn flag
• check permissions on chrome/browser/resources/webstore_app/manifest.json
• (win) remove notification support https://github.com/ric2b/Vivaldi-browser/blob/master/chromium/chrome/browser/notifications/notification_platform_bridge_win.cc#L689
• chrome/tools/build/win/create_installer_archive.py
• chrome/utility/importer/importer_creator.cc
• kMitigateUnpartitionedWebviewPermissions
• components/policy/tools/generate_policy_source.py
• Bug id 1013553 content/browser/renderer_host/render_frame_proxy_host.cc
• net/http/transport_security_state.cc check enable_staticpins
• fetcher->getServeOnlyCachedResources() why is there a property that allows the use of resources only if they are cached?
• NavigationPolicyFromEventModifiers
• library_widevine_cdm_available to true even in android
• tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/UseNetworkAnnotations.java
• a kind of safebrowsing using the list in https://downloads.vivaldi.com/blocklist/current.json
• integration of ublock, adblock and ddg rules
• changes to gn
• and many, many changes to the code of the extensions

but as I find them I will post them here.

[uazo]

but wouldn't their license model allow to apply their patches ?

I'm not worrying about that for now, are they incompatible? anyway, no intention of using exactly their code, only the ideas, I don't see anything wrong with that. and then it seems to me that they did the same with mine, or by chance we made the same changes or the changes we have made are the only ones possible.

[PF4Public]

Interesting. But wouldn't their license model allow to apply their patches ?

Quote from https://help.vivaldi.com/desktop/privacy/is-vivaldi-open-source/

All changes to the Chromium source code are made available under a BSD license and can be read by anyone on vivaldi.com/source.

[uazo]

thanks @PF4Public !

[uazo]

i.e.? BDS says it all.

[PF4Public]

@PF4Public That doesn't say anything about modification & distribution btw.

Nothing about that in your message — that I refer too — either!

i.e.? BSD says it all.

Right, but you still have to preserve license text, mention the license itself and give authorship credits.

[PF4Public]

I'm not sure which part is BSD & which one's vivaldi. https://en.m.wikipedia.org/wiki/Vivaldi_(web_browser)#cite_note-10

Do you really think they would release their closed-source UI part? I highly doubt that vivaldi.com/source has any of that. I did a cursory look at those sources several months ago searching for something specific, but it just wasn't there.

[uazo]

I finished snooping through their code.... Lots of interesting things, unfortunately nothing related to fingerprinting protection

[PF4Public]

nothing related to fingerprinting protection

Which implies they don't do that :)

[uazo]

no, I just didn't find it

[sankhababu]

no, I just didn't find it

Actually, Vivaldi is against fingerprint protection.

They have a different philosophy on that, as detailed here - https://vivaldi.com/blog/shared-networks-tracking-fingerprinting/

For fingerprint protection, it is better to take ideas from Brave (fingerprint randomization).

Vivaldi has the unique and most useful feature of setting custom speed dials like FF, but unlimited, unlike FF (Kiwi also has such).

It claims itself as a privacy browser only depending on its content blockers, nothing more! Even Google Safe Browsing can not be disabled in Mobile version!