Search engines: suggestion url should be optional

[foxjaw]

Preliminary checklist

• [X] I have read the README.
• [X] I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
• [X] I have read the FAQs.
• [X] I have updated Cromite to the latest version. The bug is reproducible on this latest version.
• [X] This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else.

Can the bug be reproduced with corresponding Chromium version?

Yes

Cromite version

120.0.6099.199

Device architecture

arm64

Platform version

Android 14

Android Device model

AOSP GSI (trebledroid)

Is the device rooted?

Yes

Changed flags

Nothing

Is this bug happening in an incognito tab?

No

Is this bug caused by the adblocker?

No

Is this bug a crash?

NO

Describe the bug

[6fba336] Search engines in chrome://settings/searchEngines page can't be added or modified either.

Steps to reproduce the bug

We can reproduce the inability of addition:

1. chrome://settings/searchEngines
2. Add Site search

   Brave
   @b
   https://search.brave.com/search?q=%s

3. Hit Save

Expected behavior

The search engine should be added

Current behavior

Where's the search engine entry ?

[uazo]

I guess you didn't enter the suggestion url, can you confirm that?

[foxjaw]

Suggestion URL is optional. You can try this on desktop by skipping it.

[uazo]

Sorry, you didn't answer me though! Could you try adding that information as well?

[foxjaw]

Sorry, you didn't answer me though! Could you try adding that information as well?

Yes. I've tried google's suggestion query but still wasn't added.
One way to mitigate this, is to use the search engine itself once, & it'll pop up in Inactive shortcuts at the bottom. Then I can able to make it the default.

But this still doesn't solve the issue, as I still can't able to edit. You can reproduce this by trying to edit the existing engines & try some modifications.

[Universalizer]

Brave Search

search.brave.com

https://search.brave.com/search?q=%s&source=web

[uazo]

From what I understand is that the suggestion url is mandatory, that is the bug.

Video

https://github.com/uazo/cromite/assets/29201891/96d8a2df-7161-488e-b54d-9820fe9fb70d

[foxjaw]

@uazo Tq. I thought it was optional since it worked on desktop for me a while ago.

[uazo]

I thought it was optional

yes, it should be

since it worked on desktop for me a while ago.

what do you mean? there is no url suggestion in chromium... I added it along with the android version. are you telling me that in the desktop it turns out optional? the code is the same....

[foxjaw]

Strange then. I use chromium (archlinux). It doesn't even have suggestions url textbox lmao.

Which is why I thought it's optional btw.

[uazo]

It doesn't even have suggestions url

Yeah, theoretically I could also add support for post mode, but since I don't understand the point of it from a privacy perspective, I didn't.

[foxjaw]

Bromite is a direct fork of chromium, & chromite is a direct fork of bromite right. In between these two projects, the suggestion url is somewhere has been either added, or the chromium built by arch linux team don't have it.
I'm not sure whether the vanilla chromium comes with suggestion url out of the box. Isn't it a google chrome feature ?

[uazo]

the suggestion url is somewhere has been either added, or the chromium built by arch linux team don't have it. Isn't it a google chrome feature ?

I have trouble understanding these sentences. I confirm that I added it (we are talking about the ability of the user to edit), you can only find it in cromite.

cromite is a direct fork of bromite right

maybe once. bromite and cromite are no longer the same thing.