uazo / cromite

Cromite a Bromite fork with ad blocking and privacy enhancements; take back your browser!
https://www.cromite.org/
GNU General Public License v3.0
3.01k stars 67 forks source link

Desktop mode not working on Tablet #756

Open shuvashish76 opened 6 months ago

shuvashish76 commented 6 months ago

Preliminary checklist

Can the bug be reproduced with corresponding Chromium version?

Yes

Cromite version

121.0.6167.101

Device architecture

arm64-v8a

Platform version

Android 9

Android Device model

Lenovo Tab4 8 Plus (TB-8704X)

Is the device rooted?

Yes

Changed flags

no flags changed

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

No

Describe the bug

For a couple of versions the desktop mode feature not working on my Tablet at all. It always uses mobile view for all the sites.

Steps to reproduce the bug

[Test1]

  1. Open any site > Click on 3dot menu > 'Click on Desktop Site'
  2. The site refresh/reloads but shows in Mobile view

    [Test2]

  3. Click on 3dot menu > Settings > User Agent
  4. Turn on "Current behaviour for desktop mode toggle in hamburger menu" (used default "standard user agent" for both Mobile and Desktop)
  5. Site Settings > Turn on "Desktop site"
  6. Open any site > refresh > still shows in mobile view
  7. Close-reopen Cromite app > Open any site > refresh > same mobile view for all sites.

Expected behavior

It should open sites in Desktop view if enabled. Also note that I tested on my another phone (android 8.1.0) it works as expected so I assume this bug is related to Tablet only.

Screenshots

No response

uazo commented 6 months ago

I don't detect any bug, can you tell me a url to try it with?

shuvashish76 commented 6 months ago

I tried with multiple websites e.g.

https://github.com/ https://lichess.org/ https://www.pychess.org/ https://en.wikipedia.org/wiki/Main_Page https://www.eff.org/ etc..

uazo commented 6 months ago

no problem at all. I remind you that one thing is what the browser says and one thing is what the site wants to do.

For example: image

Desktop mode: image

try with https://www.whatismybrowser.com/detect/what-is-my-user-agent/

shuvashish76 commented 6 months ago

Mine shows Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36 - for Desktop mode Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36 - for Mobile

uazo commented 6 months ago

so it works.

shuvashish76 commented 6 months ago

🤷🏿 No it doesn't work for me. But no such issues on my phones, tried with both android 8 & 12.

uazo commented 6 months ago

Mine shows Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36 - for Desktop mode Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36 - for Mobile

is correct, and that is what it is intended to do

shuvashish76 commented 6 months ago

User agents shows correct (!?) but sites never switch to desktop mode, weird.

one thing is what the browser says and one thing is what the site wants to do.

On tablet I prefer desktop modes but I guess I'll live with this mobile view issue🤷🏿 Though on Mull browser sites works as Desktop view as expected on this Tablet.

I see it's not a bug from your side, thanks for the quick replies.

uazo commented 6 months ago

I advise you to try a rollback to the previous version and see if the behaviour is identical.

shuvashish76 commented 6 months ago

As I said I'm experiencing this issue for a while now, so sorry for not reporting back then.

I checked multiple versions back and forth. The v116.0.5845.188 (584518804) version works as expected for me but when updating to v117.0.5938.63 (593806304) this issue reappears. I'm sure something must have been changed from major v117.x.x

prasetyodedy commented 3 months ago

I encountered a similar issue, where desktop mode failed to run on a tablet with portrait view.

almost all popular sites crash and broke when requesting desktop mode with portrait view. ½ Google drive display blank page, gmail can't fit displaying desktop mode. github still mobile mode, and many of popular website broke.

all is fine with landscape view.

uazo commented 3 months ago

almost all popular sites crash and broke when requesting desktop mode with portrait view

could you check how chrome behaves?

prasetyodedy commented 3 months ago

work without any problem on another chromium browser "samsung, vivaldi, kiwi" all of them can run desktop mode in portrait view.

(edit) edge, chrome, thorium, brave & cromite make broke like this in Chromium 124 Screenshot_20240418_073516 Screenshot_20240418_073922 Screenshot_20240418_073530