search

ubaransel / lgcommander

Other
136 stars 43 forks source link

Clean up and combined scripts into one script and added command line interface. #4

Closed ypid closed 9 years ago

ypid commented 9 years ago

You might want to put the script under a license …

ubaransel commented 9 years ago

Thanks for the pull request. I would prefer to provide a link to your version rather than merge it. Reason: Your version with command line options (and Readme which refers to "./lgcommander.py" which would only work in *nix) would probably confuse windows users who prefer just clicking things. As a result I would probably get a lot more emails seeking help. Linux users have never asked for help.

ypid commented 9 years ago

I have never run python on Windows … I heard that Python supports Windows but who knows :smile:.

If that is your only reason for not merging it, fixed it …

For the part of Windows uses who just want to click on things I would suggest that you add a short note that they should change this line, they can also specify the paring key that way.

ubaransel commented 9 years ago

The script works in windows if you click on it.

in README you shouldn't talk about things like FQDN, mulicast (spelling error here) request TCP port, ROSP (spelling error here) and HDCP etc.

the script should somehow work without requiring command line options. for example it should autodetect whether ROAP or HDCP it should report errors in gui or pop up.

Otherwise you would be answering a lot of emails from unhappy windows users (as I did). who have probably never used used cmd.exe

to further improve it you may want to make it work with both py3 and py2 to make linux users (who have py2 by default) happy (see first pull request).

On Thursday 14 August 2014, Robin Schneider wrote:

I have never run python on Windows … I heard that Python supports Windows but how knows :smile:.

If that is your only reason for not merging it, fixed it …

Reply to this email directly or view it on GitHub: https://github.com/ubaransel/lgcommander/pull/4#issuecomment-52238834

ypid commented 9 years ago

Good idea. Sorry for the typos. I start to like the script :smile:. I find python3 is a good choice and personally, I see no reason or need to make it compatible with python2 nowadays.

ypid commented 9 years ago

Anything holding you back merging the thing?

ubaransel commented 9 years ago

I am not able to test your version. So instead of merging, I have added a link in README to your fork.