Create a cmake export target

ubarsc / kealib

KEALib provides an implementation of the GDAL data model. The format supports raster attribute tables, image pyramids, meta-data and in-built statistics while also handling very large files and compression throughout.

http://kealib.org/

MIT License

12 stars 7 forks source link

Create a cmake export target #31

Closed gillins closed 1 year ago

gillins commented 1 year ago

And use it when building the Python bindings.

Should make it easier for cmake projects to link against libkea.

dg0yt commented 10 months ago

Given the project name and the Kealib target name, it might have more sense to create Kealib CMake package with a Kealib::Kealib target. Or is this something which would be still considered worth adopting?

gillins commented 10 months ago

Given the project name and the Kealib target name, it might have more sense to create Kealib CMake package with a Kealib::Kealib target.

Agreed. Perhaps we can change this for 1.6.0 (I'm hoping to push out 1.5.3 soon)? 1.6.0 will have some larger changes so that would be a good time to rename.

dg0yt commented 10 months ago

It might be possible to have both in 1.5.3, and then remove the other one in 1.6.0.

gillins commented 10 months ago

It might be possible to have both in 1.5.3, and then remove the other one in 1.6.0.

That's a good plan. Are you happy to create a PR for this?

dg0yt commented 10 months ago

I can do that. With your indication of acceptance, I can test this in the vcpkg port as part of a fix which includes a usage synopsis. And I would prefer to never document anything else ;-)

However, to minimize impact, I suggest two steps:

For 1.5.3: Leave export mostly as is, and generate the Kealib config/namespace as a separate trivial config file / interface target. This will leave all existing targets where they are now.
for 1.6.0: Get rid of all libkea config/namespace stuff, and move to Kealib-only.

gillins commented 10 months ago

Sounds good. We'd also have to submit something to GDAL that looks for the new target, but can also try the old one (for people still on older kealib). Not sure if this is possible?

dg0yt commented 10 months ago

We'd also have to submit something to GDAL that looks for the new target, but can also try the old one (for people still on older kealib). Not sure if this is possible?

This is where I come from: https://github.com/microsoft/vcpkg/pull/35437/files Once Kealib's CMake config is stable, we can look at a GDAL PR.