search

ubarsc / pyshepseg

Python implementation of image segmentation algorithm of Shepherd et al (2019) Operational Large-Scale Segmentation of Imagery Based on Iterative Elimination. Remote Sensing 11(6).
https://www.pyshepseg.org
MIT License
10 stars 4 forks source link

move to entry points instead of our own command line programs #38

Closed gillins closed 1 year ago

gillins commented 1 year ago

More 'standard' and works properly under Windows.

Note that the new entry points don't have the .py extension (they get stripped off under Windows anyway).

Also, I've taken the scripts as they are. Not sure if other changes need to be made. They are also still executable.

neilflood commented 1 year ago

I think the packages= argument needs to include 'pyshepseg/cmdline'.

neilflood commented 1 year ago

I think this all looks good. Just a quibble on the wording in the cmdline/init docstring. I think, technically, cmdline is a "sub-package with modules ...". And they are "intended for calling from the command line". Just details, nothing serious, and I don't mind if you ignore me :-)

gillins commented 1 year ago

Good spotting, must have been asleep. All good to merge?

neilflood commented 1 year ago

Yup, I think that's ready to go. Very good.