search

ubarsc / rios

A raster processing layer on top of GDAL
https://www.rioshome.org
GNU General Public License v3.0
15 stars 8 forks source link

Cope with numpy-1.24 type symbol deprecations #52

Closed neilflood closed 1 year ago

neilflood commented 1 year ago

This now passes standard tests under numpy-1.24.0.

neilflood commented 1 year ago

Dammit, a typo in the commit message - I hate that......

gillins commented 1 year ago

Should we also be coping with int64/uint64 (not sure why we didn't do this earlier). And the int8 support coming to GDAL soon (https://gdal.org/development/rfc/rfc87_signed_int8.html)....

gillins commented 1 year ago

Dammit, a typo in the commit message - I hate that......

You can edit the title of this PR at least. When you do a squash and merge the originally commit message will be lost anyway.

neilflood commented 1 year ago

I think we do already cope with int64/uint64. There is a little extra couple of lines to add to that list, if gdalconst has GDT_Int64.

Thanks, edited the title, at least :-)

neilflood commented 1 year ago

By the way, I also tested these changes under numpy-1.23, and it works fine there, too.