search

ubarsc / rios

A raster processing layer on top of GDAL
https://www.rioshome.org
GNU General Public License v3.0
14 stars 7 forks source link

ImageReader raises NotImplementedError #89

Closed petebunting closed 2 months ago

petebunting commented 2 months ago

Commented out a call to ReaderInfo setBlockDataset, which has been refactored to produce a NotImplementedError, and therefore, anything using the ImageReader class cannot run.

I noticed that ImageReader has been deprecated and I will rework the few functions in RSGISLib which use this class. I ran the RSGISLib test suite with this line commented out and the tests passed so I think things are working OK without this function call but @gillins and @neilflood you'll know better than me 😄

neilflood commented 2 months ago

Thanks @petebunting

Good point :-) That should be removed completely. If you remove lines 921 to 925, that should do it, and then I will merge it. You are right, it should make no difference to the sorts of things you would use it for. Hopefully you can easily re-work to avoid use of ImageReader altogether, but let me know if there is some insurmountable hurdle.

petebunting commented 2 months ago

Thanks @neilflood,

Yes, shouldn't be a problem to remove ImageReader from RSGISLib. I think it is just 5 functions which would need to be refactored.