scroll to previous/next selected

ubarsc / tuiview

TuiView is a lightweight raster GIS with powerful raster attribute table manipulation abilities

http://tuiview.org/

GNU General Public License v2.0

26 stars 13 forks source link

scroll to previous/next selected #68

Closed gillins closed 9 months ago

gillins commented 9 months ago

Has it happened to you where you've done a geographic select or a select by expression and it scrolls to the first row but then you struggle to find any of the other rows that are selected? This is becoming more of a problem with bigger RATS...

So I've added a fast forward and rewind icon to the top and bottom of the scroll bar to scroll to the next or previous selected row. @neilflood @petescarth can you guys give this a quick test and let me know if this is ok?

neilflood commented 9 months ago

Yes, just tried it, and it seems to work. I do agree that for large-ish RATs, scrolling through the table looking for something is essentially unusable, so it is certainly good to try to address it.

The tooltip text on those buttons seems strangely worded.
I could not quite work out how it decided the amount to scroll by, but it seemed to be usable, so fine.
Would this be better done by just giving a "Display only selected rows" toggle? I am unsure either way, I was just wondering.

Well done, though.

gillins commented 9 months ago

Thanks for checking.

re: tooltips. Open to suggestions, was trying to avoid the words "previous selected" as this might mean the last set of rows selected rather than "towards the top of the RAT". What do you think the best wording would be.

re: amount to scroll. It tries to move the newly found row to the middle of the current page. Not sure I have this right though...

re: "Display only selected rows". Yes, maybe. But would be more work...

neilflood commented 9 months ago

re: tooltips. Yes, I get what you are saying about words like "next" and "previous". However, I think the problem is that you accidentally included the word "to" twice. Should this be "Scroll up to selected" ? That would make better sense.

gillins commented 9 months ago

Ah yes you are right! Try that.

neilflood commented 9 months ago

Much better :-)

gillins commented 9 months ago

If you think this is an acceptable solution for now, I'll merge this. Doing the "Display only selected rows" is Quite Hard (will discuss details with @neilflood). We'd want to be certain it's the way to go before embarking....

neilflood commented 9 months ago

I am certainly happy with this idea. I don't have strong feelings about the other approach, I was just thinking aloud.