Node upgrade fixes from the error in the merge earlier.

ubc-biztech / serverless-biztechapp

biztech's backend. AWS lambda, cognito, dynamodb, written in Node js

2 stars 1 forks source link

Node upgrade fixes from the error in the merge earlier. #354

Closed jaypark25 closed 2 weeks ago

jaypark25 commented 2 weeks ago

🎟️ Ticket(s): Closes #352

👷 Changes: Fixed spacing and wrote into serverless.common.yml

Wait! Before you merge, have you checked the following:

[ ] Serverless tests are passing (Check travis build logs, CI is currently broken)
[ ] PR is has approving review(s)

jaypark25 commented 2 weeks ago

@voctory could you take a look at this? Fixed serverless.common.yml per your advice. Should I look into testing with sls deploy? Or do you think merging into dev environment is sufficient?

voctory commented 2 weeks ago

Hey Jay! Thanks for the fix on this - I know it goes against what I suggested last time, but with this change I'd be ok with merging into dev, just make sure to change the target branch from master to dev and I can approve

In the future, I think we'd prefer an sls deploy before merging (especially for larger changes) as it might help to catch deploy issues more quickly. I'll discuss with Allan

jaypark25 commented 2 weeks ago

Closing as its for master oops