Example cases - Githubissues

ubc-carnap-team / Rudolf

Truth Tree Widget for Carnap

2 stars 3 forks source link

Example cases #23

Closed kylemas closed 5 years ago

kylemas commented 5 years ago

New pull request for changes in the handleSubmit method under PremisesSelector component.
Changed FormEventHandler to ChangedEventHandler
Changed HTMLFormElement to HTMLSelectElement
Reverted type of handleSubmitPremises on App.tsx back to 'string' from 'any'.
Changed definition of premises variable under handleSubmit on PremisesSelector.

McTano commented 5 years ago

There are still eslint errors on the latest commit. Run yarn eslint or use vscode's problems view (the little (X) and /!\ icons on the bottom panel to see the eslint errors.

kylemas commented 5 years ago

There are still eslint errors on the latest commit. Run yarn eslint or use vscode's problems view (the little (X) and /!\ icons on the bottom panel to see the eslint errors.

I tried running 'yarn eslint' as well as checking the problems view on vscode. I'm not really sure what I'm looking for?

McTano commented 5 years ago

Sorry, that should be yarn lint.

McTano commented 5 years ago

When you open the PremisesSelector file in vscode, you should be able to see the errors highlighted. Do you have the eslint extension installed?

McTano commented 5 years ago

Since the PremisesSelector file is open in your screenshot, you should be able to see the errors in problems view. It must not be set up right.

kylemas commented 5 years ago

Since the PremisesSelector file is open in your screenshot, you should be able to see the errors in problems view. It must not be set up right.

Yeah, I didn't have the eslint extension installed. I fixed up the issues/warnings now!