search

ubc-carnap-team / Rudolf

Truth Tree Widget for Carnap
2 stars 3 forks source link

Space out formulas vertically so that each row lines up. #39

Closed McTano closed 4 years ago

McTano commented 4 years ago

When a user appends new nodes to the bottom of all open branches in part of the tree, some branches may be shorter than others. The new nodes should be spaced consistently so that uneven branches can line up when they receive new nodes which start on the same row.

McTano commented 4 years ago

Example: uneven_rows

The formulas on row 6 should appear at the same height vertically. As you can see, there is some logic which attempts to get this right and draws a bit of extra line on the left, but it doesn't quite work.

orbit-stabilizer commented 4 years ago

I get something different when I run that example. Is what I have the expected behaviour?

image
McTano commented 4 years ago

It looks like you added the resolution for P&Q to each branch separately. On the left you've got 6,7 and on the right I think the checker would accept that as correct, but I'm not sure. To reproduce the behaviour above you need to right-click a formula above where they branch (e.g. row 2) and select "continue branch with 2 nodes". Then you'll get row 6,7 on both sides.