search

ubc-carnap-team / Rudolf

Truth Tree Widget for Carnap
2 stars 3 forks source link

Add development environment setup instructions #45

Closed lf- closed 4 years ago

lf- commented 4 years ago

I had a slight bit of difficulty figuring out the development environment, so let's document it!

lf- commented 4 years ago

I have implemented the suggested changes. We now have a more readable bulleted list of setup instructions.

The credit line has been reinstated but moved below a horizontal divider between the project specific stuff and the create-react-app documentation.

McTano commented 4 years ago

That is interesting. I didn't know there was a Yarn 2. We'll have to look into upgrading.

On Sat, May 23, 2020 at 12:34 AM lf notifications@github.com wrote:

@lf- commented on this pull request.

In README.md https://github.com/McTano/Rudolf/pull/45#discussion_r429523434:

@@ -1,4 +1,8 @@ -This project was bootstrapped with Create React App. +## Development Environment Setup + +First, install the package manager yarn from your system package manager or with npm install -g yarn. Ensure you have git submodules set up for this project with git submodule update --init.

Re: the yarn thing, I mistakenly thought we were using Yarn 2, for which that is the recommendation. I changed it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/McTano/Rudolf/pull/45#discussion_r429523434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFHH6SUR6742G4MTSDLZO3RS54B7ANCNFSM4NGSVUPQ .

McTano commented 4 years ago

Thanks a lot for improving the documentation!