search

ubc-carnap-team / Rudolf

Truth Tree Widget for Carnap
2 stars 3 forks source link

pass dimensions to LineTo component as key prop #64

Closed McTano closed 4 years ago

McTano commented 4 years ago

Fixes #63

mbecker20 commented 4 years ago

Perfect, no slowness. Good to see how to add stuff to the state system. Probably hold off on merging to master until we decide whether to switch to react archer

McTano commented 4 years ago

Perfect, no slowness. Good to see how to add stuff to the state system. Although this probably shouldn't be merged to master if we are switching to react archer

That's good. I think the key difference from this implementation and what you described is that the onresize listener only triggers a single update to the store on the App component, instead of a setState for each component.

I'm going to merge it anyways. It won't make it much harder to switch to react-archer. Just need to remove the useEffect and the new reducer action.