search

ubc-carnap-team / Rudolf

Truth Tree Widget for Carnap
2 stars 3 forks source link

Move row numbers and justifications outside scrollable box #78

Open McTano opened 4 years ago

McTano commented 4 years ago

Since the row number and justification are relevant no matter which sub-branch you're working on, I was thinking maybe they should be moved outside the scrollable container so that they can always be seen, even if you're looking at the middle part of the tree.

Just a thought. Anyone have opinions on this?

mbecker20 commented 4 years ago

Maybe the justifications could act as they do now when they are in view, but as they are scrolled horizontally out of the tree window, they "catch" on the edge, and the rest of the tree keeps scrolling underneath them. I think this could be better because the justifications still have to scroll vertically to stay horizontally aligned with the appropriate tree row, and being inside the scroll window gives the overlapping content a clean edge when it is inserted as a widget ( otherwise you have Rudolf content overflowing outside of it's widget bounds, or an unnatural hard stop to the content without a border)

McTano commented 4 years ago

Yeah, That would be better. I wasn't thinking about vertical scrolling.

On Sat, Aug 1, 2020, 10:44 AM mbecker20 notifications@github.com wrote:

Maybe the justifications could act as they do now when they are in view, but as they are scrolled horizontally out of the tree window, they "catch" on the edge, and the rest of the tree keeps scrolling underneath them. I think this could be better because the justifications still have to scroll vertically to stay horizontally aligned with the appropriate tree row, and being inside the scroll window gives the overlapping content a clean edge when it is inserted as a widget ( otherwise you have Rudolf content overflowing outside of it's widget bounds

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/McTano/Rudolf/issues/78#issuecomment-667564919, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFHH6RLF5LJ2RSAYRFYAS3R6RIBDANCNFSM4PRKYOGQ .