search

ubc-cpsc / jekyll-clf-theme

A UBC CLF theme for Jekyll
MIT License
1 stars 1 forks source link

Formatting of navigation sidebar #3

Open stephan-koenig opened 1 year ago

stephan-koenig commented 1 year ago

Hi,

The headers in the navigation sidebar are expanded instead of hidden, so all subheaders are visible on page load, and the subheaders are formatted differently compared to UBC CLF.

navigation_sidebar

joelpittet commented 1 year ago

Thanks @stephan-koenig I'll look into fixing this styling shortly, glad to see you are trying it out!

stephan-koenig commented 1 year ago

Thanks, @joelpittet!

joelpittet commented 1 year ago

@stephan-koenig I was thinking of taking the styles from this UBC site, it's not the CLF one as I think it's a bit nicer. Thoughts before I do that? https://finance.ubc.ca/payroll/your-pay

Or the one we use for CS: https://www.cs.ubc.ca/students/undergrad/careers

Preferences?

stephan-koenig commented 1 year ago

I think I like the first one better: https://finance.ubc.ca/payroll/your-pay

@rloftus, what do you think?

rloftus commented 1 year ago

I agree, the first one is better @stephan-koenig

joelpittet commented 1 year ago

Ok it's not 100% there yet but there is some progress.

joelpittet commented 1 year ago

0.3.0 of the theme has the new style, use bundle update to see

stephan-koenig commented 1 year ago

Ok it's not 100% there yet but there is some progress.

Looks already very neat! Thanks!

  • [ ] Need to potentially collapse trees that are not active: @stephan-koenig Is what you're aiming for? This can be tricky because of the static nature of the way the menus are produced but probably not impossible.

I imagined that the navigation is interactive, i.e., clicking on the top level would reveal the child pages for any menu item. But yes, ideally, all submenus except the current one should be collapsed.

  • [ ] Maybe more important the sub menu should probably not show the top level menu items but rather only the child pages?

I think it is better if the top level is shown so people know, e.g. if they are looking at the "Student Info" or "Faculty Info."

What do you think, @rloftus or @cheeren?

joelpittet commented 1 year ago

@stephan-koenig generally in the CLF the side menu shows the secondary menu items (if they exist) and the primary menu items are shown across the top. Are you proposing an alternative to that?

Regarding the interactivity, I was thinking the sub menu in the side menu would expand if you're on that "branch" (parent or child menu items), and siblings that have sub menu items would be collapsed by default but clicking the arrow would expand them, clicking the text would go to that page. That pattern is on the CS external website https://www.cs.ubc.ca/students/undergrad/careers

stephan-koenig commented 1 year ago

I must have misunderstood. The behaviour as you describe it sounds excellent!

joelpittet commented 1 year ago

Ok great, I'll try to sneak some time in on Friday to push this a bit further