Closed Lowie375 closed 2 years ago
Refactor is mostly complete! Will re-open the PR once support for tool groups has been re-implemented
Have noticed a couple of issues that need to be fixed with mc_toolhandler
; marking as draft until those have been fixed
I am not sure which commit deleted it, but we should probably automatically check and ensure that all players join the game with the student notebook and the tutorial notebook and all teachers join with the student notebook, the teacher remote, and the tutorial notebook.
Noted! Will add a property that allows the default inventory for an item to be overridden. That should allow tools like the student notebook and teacher tools to always go to the "main" inventory
Also, I noticed that the tutorial recording tool is still automatically given from an on_joinplayer callback somewhere and is not registered in the toolhandler system yet. Is that forthcoming in the draft tutorial framework PR?
Yep, that has been changed on the features/tutorial_recording
branch. However, that branch is using an older version of mc_toolhandler
, so I'll just register the tools on this branch and merge develop
into features/tutorial_recording
after this PR is pushed
mc_toolhandler
registration flowmc_toolhandler
mc_toolhandler
a dependency instead of a dependent when registering toolsmc_toolhandler
put managed tools into toolbox by default (ifmc_toolmenu
is present)inv_override
property to allow tools to be placed in different player inventory lists by defaultmc_toolhandler
withmc_helpers
equivalentsget_player_item_location
function intomc_helpers.getInventoryItemLocation
list_info
local