ubc-minetest-classroom / minetest_classroom

Repo for Mintest Classroom game
GNU General Public License v3.0
10 stars 6 forks source link

Improve `mc_toolhandler` system #138

Closed Lowie375 closed 2 years ago

Lowie375 commented 2 years ago
Lowie375 commented 2 years ago

Refactor is mostly complete! Will re-open the PR once support for tool groups has been re-implemented

Lowie375 commented 2 years ago

Have noticed a couple of issues that need to be fixed with mc_toolhandler; marking as draft until those have been fixed

Lowie375 commented 2 years ago

I am not sure which commit deleted it, but we should probably automatically check and ensure that all players join the game with the student notebook and the tutorial notebook and all teachers join with the student notebook, the teacher remote, and the tutorial notebook.

Noted! Will add a property that allows the default inventory for an item to be overridden. That should allow tools like the student notebook and teacher tools to always go to the "main" inventory

Also, I noticed that the tutorial recording tool is still automatically given from an on_joinplayer callback somewhere and is not registered in the toolhandler system yet. Is that forthcoming in the draft tutorial framework PR?

Yep, that has been changed on the features/tutorial_recording branch. However, that branch is using an older version of mc_toolhandler, so I'll just register the tools on this branch and merge develop into features/tutorial_recording after this PR is pushed