search

ubc-minetest-classroom / minetest_classroom

Repo for Mintest Classroom game
GNU General Public License v3.0
10 stars 6 forks source link

Biomegen decorator produces mismatched decorations #148

Closed pauldpickell closed 2 years ago

pauldpickell commented 2 years ago

Describe the bug Using the biomegen key for the decorator can create some weird results. Not sure if this is a bug of the biomegen mod or on our end, but I found some hybrid poplar-apple trees.

To Reproduce Steps to reproduce the behavior:

  1. /realm new
  2. /realm tp 2
  3. /realm gen 2 v2 biomegen 10 123
  4. See result

Expected behavior Should not see hybrid trees.

Screenshots image

Desktop (please complete the following information):

lukasgolson commented 2 years ago

This looks like a bug in biomegen and how it has 3D height-based biomes. I'll fix this issue by setting biomes to be the same throughout each vertical slice of a realm.

lukasgolson commented 2 years ago

On further inspection, this does not look to be a bug with biomegen or our mod; or if it is, it is incredibly tough to debug.

Rather I think it might be dependent on the specific schematic registered in the Minetest engine. All other tree schematics appear to be working correctly, except this "hybrid" one. As soon as I started logging the name of each schematic when it is placed, this bug stopped occuring... Strange... I will keep digging.

pauldpickell commented 2 years ago

Fixed by #157

lukasgolson commented 2 years ago

Just looked into it briefly, this looks to be a known bug in biomegen. I’ll patch this on Monday.

On Jul 28, 2022, at 4:52 PM, pauldpickell @.***> wrote:



Describe the bug Using the biomegen key for the decorator can create some weird results. Not sure if this is a bug of the biomegen mod or on our end, but I found some hybrid poplar-apple trees.

To Reproduce Steps to reproduce the behavior:

  1. /realm new
  2. /realm tp 2
  3. /realm gen 2 v2 biomegen 10 123
  4. See result

Expected behavior Should not see hybrid trees.

Screenshots [image]https://user-images.githubusercontent.com/61996662/181655684-ed6be22b-58a3-4abf-85d4-84fc482626fc.png

Desktop (please complete the following information):

— Reply to this email directly, view it on GitHubhttps://github.com/ubc-minetest-classroom/Minetest_Classroom/issues/148, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABXNSTQH75FID33EKR3MQALVWMMLPANCNFSM5467VI2A. You are receiving this because you were assigned.Message ID: @.***>