ubc-minetest-classroom / minetest_classroom

Repo for Mintest Classroom game
GNU General Public License v3.0
10 stars 6 forks source link

HUD marker does not display correctly for players in a classroom #220

Closed pauldpickell closed 1 year ago

pauldpickell commented 1 year ago

Describe the bug When a player records a coordinate in a classroom and then clicks the place a marker button, the HUD marker appears only for the player who placed the marker.

To Reproduce Steps to reproduce the behavior:

  1. Open student notebook.
  2. Navigate to Map tab.
  3. Type a message and click Save Current Coordinates.
  4. Highlight the new message in the list and then click the place marker in world button.
  5. Observe that other players cannot see the HUD marker that is being shared.

Expected behavior All other players in the classroom should be able to see the HUD marker. Need to take care that minetest.register_on_joinplayer and minetest.register_on_leaveplayer are set up to manage these HUD markers for players that are coming and going as well as when players teleport between classrooms.

Desktop (please complete the following information):