search

ubc-web-services / Megatron

Drupal 7 theme for the UBC CLF
http://ubc-web-services.github.com/Megatron/
9 stars 8 forks source link

Alert warning #41

Closed joelpittet closed 7 years ago

joelpittet commented 8 years ago

There doesn't seem to be styles for the warning status in the CLF http://clf.ubc.ca/design-specifications/components.html#alerts

The warning they give an example for is very similar to the alert.

Any chance we can make one up?

Something like this:

components___ubc_clf__common_look_and_feel_

occupant commented 8 years ago

I don't find the default styles for these to be very good - the titles and links often have strange colours.

I use these most of the time (with error / danger and info / status sharing a style): screen shot 2016-10-11 at 10 18 11 am I'm happy to add these, but I think it should be a set of opt in styles since we're clearly off CLF.

joelpittet commented 8 years ago

Those look way better! I agree about the clash color titles. Maybe we can add as an alternative? Like add a theme setting and class in preprocess?

occupant commented 8 years ago

Sure, I can add a theme setting, then add the additional css file if needed. It uses all the same markup, so I don't think I'll need the preprocess class.

joelpittet commented 8 years ago

What do you think about keeping the colors to match the CLF as much as possible, and remove the rounded corners? I'm not sure how much to push the colors but maybe something like this would work? Feel free to play with the colors, I used tints and complements of existing colors.

https://jsfiddle.net/q8qLe4y8/

joelpittet commented 7 years ago

I can make a PR if you think this would work?

occupant commented 7 years ago

That sounds great. I've been meaning to get to this but it's always last on the list :)