ubc-web-services / Megatron

Drupal 7 theme for the UBC CLF
http://ubc-web-services.github.com/Megatron/
9 stars 8 forks source link

LESS #57

Closed darko-hrgovic closed 5 years ago

darko-hrgovic commented 6 years ago

We might think about standardizing LESS in develop branch. For example, off.canvas.drawer.less exists, but navigation.sticky.less does not.

We might also suggest a standard approach to minification in README.md, like less-plugin-clean-css

joelpittet commented 6 years ago

I'm for standardizing the LESS files, but personally prefer to move to SASS, but +1 for standardizing.

Regarding minification though, I'd suggest we don't minify and let Drupal do that.

darko-hrgovic commented 6 years ago

+1 on all counts

Jens prefers to keep the grad css uncompiled, but the Megatron would be good as SASS (like your basic theme :-). I came across it as LESS and continued down that road. The drawer css would need to be ported to SASS in that case.

darko-hrgovic commented 6 years ago

How about a gulp config, too? (again, like in basic theme :-)

occupant commented 6 years ago

Yes, it would be good to port everything to sass - we’ve already moved that way in galactus. And we’ve dropped minification, so it makes sense to do that here too.

For the sass compiling / autoprefixing, Joel added yarn to galactus instead of a gulp / grunt process. I haven’t really worked with it yet, but I’d suggest that that as an alternative to gulp. And, to add to the list, I’d love to get some linting in here.

darko-hrgovic commented 6 years ago

Love it.

Since I'm new to this party, wondering who is doing what with Megatron/Galactus at this point?

And James, aren't you on holiday? ;-) Enjoy!

joelpittet commented 6 years ago

Anybody is doing anything if they can:)

Here's the PR for SASS https://github.com/ubc-web-services/galactus/pull/17

You'll see the yarn scripts to help reduce dependencies on ecosystems of task runner wrappers like gulp/grunt/etc. I'm following this general philosophy https://medium.freecodecamp.org/why-i-left-gulp-and-grunt-for-npm-scripts-3d6853dd22b8

occupant commented 5 years ago

This is in develop now (at least as a start). Only took a year! hah f69198a