Open darko-hrgovic opened 6 years ago
occupant
commented
5 years ago Hi Darko, I'm finally getting back to Megatron (had a bug I had to fix), so I should get this in there too :)
Just wondering about the 3 pull requests - this one includes #58 and #59, is that correct?
Let me know and I'll go through everything here and we can get it into place.
darko-hrgovic
commented
5 years ago Cool, James.
The flyout branch is rather old at this point and a ton has been added in our child themes to make it all work. Not sure of the ROI of wedging this into a theme that few people will use going forward. I had a chance to deploy your D8 Galactus theme on a D7 upgrade attempt and I'll eventually need to add the flyout to that theme so it might make sense to wait until then?
Perhaps a quick chat this week? We have free coffee :-)
On Mon, Jun 17, 2019 at 9:59 PM James notifications@github.com wrote:
Hi Darko, I'm finally getting back to Megatron (had a bug I had to fix), so I should get this in there too :)
Just wondering about the 3 pull requests - this one includes #58 https://github.com/ubc-web-services/Megatron/pull/58 and #59 https://github.com/ubc-web-services/Megatron/pull/59, is that correct?
Let me know and I'll go through everything here and we can get it into place.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ubc-web-services/Megatron/pull/60?email_source=notifications&email_token=AAM3ZLMB47SZDXXX7PKKDFTP3BTSBA5CNFSM4FHJBGF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX5F3KA#issuecomment-502947240, or mute the thread https://github.com/notifications/unsubscribe-auth/AAM3ZLO6DK74FG27ANKMMA3P3BTSBANCNFSM4FHJBGFQ .
Flyout button z-index lower than mobile menus
Main menu items with no children need bg color so flyout button doesn't poke through
Moved flyout button out of nav structure in page.tpl.php so z-index on menu works
Other improvements/fixes to make it work with our flyout needs