search

ubc-web-services / galactus

A Drupal version of the UBC CLF theme
MIT License
6 stars 5 forks source link

Wrap title and node__meta in header region, remove footer element #26

Closed occupant closed 6 years ago

occupant commented 6 years ago

The default classy node template inserts the node__meta into a footer element, and then adds this prior to the primary content. This seems counterintuitive and potentially poor usage.

I'm not sure this is a good way to solve this, but putting it out there for discussion.

occupant commented 6 years ago

Perhaps removing the header element and leaving node__meta a div would be better? I hate to add markup if it doesn't add any value semantically or for display.

joelpittet commented 6 years ago

I think your suggestion to remove the wrapping element together makes sense as it won't affect existing sites and one less element!

occupant commented 6 years ago

Agreed - pulled out the header tag.