ubc-web-services / galactus

A Drupal version of the UBC CLF theme
MIT License
6 stars 5 forks source link

Clf local options #57

Closed occupant closed 1 year ago

joelpittet commented 3 years ago

@occupant The "Use Minimal CLF" doesn't work if local is chosen. Maybe we can hide and disable that option if they choose local?

joelpittet commented 3 years ago

Screen Shot 2021-07-02 at 17 07 50-fullpage Screen Shot 2021-07-02 at 17 07 43-fullpage @occupant Currently something's not quite right with local, uploading screenshots of the homepage

joelpittet commented 3 years ago

A big part of why they are broken is mostly because I overwrote the generic .container classes and now local is more specific...

occupant commented 3 years ago

@occupant The "Use Minimal CLF" doesn't work if local is chosen. Maybe we can hide and disable that option if they choose local?

Right, the help text does note that it's just there for legacy purposes (to prevent existing settings from being lost), but hiding it altogther is a much better option.

occupant commented 3 years ago

A big part of why they are broken is mostly because I overwrote the generic .container classes and now local is more specific...

Right, this has been an ongoing issue (the name is just too generic and too likely to be used by other css). I'd prefer to change the markup to reference clf-container and the CSS accordingly, but that would necessitate a change to the page.html.twig. That said, I think it's a good thing to move forward with. Thoughts on that?

EDIT: or am I misunderstanding the issue? Just reread it and I'm not quite sure. Do you mind posting your container style overrides?

joelpittet commented 3 years ago

Some of this I can deal with because I caused it and it's meant for expert level. So I think I'm game for merging with that class added back

joelpittet commented 3 years ago

@occupant I'm on board with the .clf-container change idea, and that it only adds it when local is chosen.

darko-hrgovic commented 3 years ago

+1 for changing to .clf-container

darkodevubc commented 3 years ago

I was going to also correct "Use an external, minimal copy of the CLS [sp] css files." but I think that's going away, non?