ubc / iPeer

Peer Evaluation System
http://ipeer.ctlt.ubc.ca
Other
17 stars 18 forks source link

Groups with only new iPeer users are empty after import #600

Closed kitsook closed 5 years ago

kitsook commented 5 years ago

When importing groups from Canvas, if the group only contains new iPeer users, the user accounts are created and the group is also created. However, none of the new users are added as member into the group.

Logic in group controller failed to count the newly created iPeer users and incorrectly treated the group as empty.

https://github.com/ubc/iPeer/blob/f6ad05b0f9b73afeda022ded15616d71abe50cb9/app/controllers/groups_controller.php#L1159-L1166

Before this bug is fixed, an interim solution is to import students before importing groups. Or, executing group import twice (so that new users are created in the first group import and so the second run of group import will assign membership correctly)

Ref: PRB0044187