Closed stemar closed 3 years ago
Oh DATABASE_VERSION
in core.php does need to be changed to 18 for sure though
Resolved.
Looking into it some more, it doesn't look like registration.json
is used?
And there is no way that I can find for an admin to edit the lti_tool_registrations
and lti_platform_deployments
table entries through the UI.
Not sure if I'm missing something though (for now, I'll just manually edit the db entries to continue testing)
Alright I can't get launches to work correctly at the moment. after figuring out the composer version issue, I'm now getting warnings that I need to suppress
$redirect = $login->do_oidc_login_redirect($url);
-> $redirect = @$login->do_oidc_login_redirect($url);
and error message State not found
not sure if its related to the imsglobal/lti-1p3-tool
version or not though
Okay after talking with @stemar about the issue I was having, its because I didn't apply the Cookie.php.diff
patch to the imsglobal/lti-1p3-tool
Cookie.php
file.
I suggested that we either fork the imsglobal/lti-1p3-tool
and apply our fixes to that and work off that for now (so deployment will be easier since noone will need to patch the lib). We can also make a PR to the ims repo supplying them with the fix we need.
Alright, I'm done reviewing for now
closing in favor of #661
I don't recall how we handle iPeer version changes with regards to db changes in PRs but I needed to manually update the
version.txt
andIPEER_VERSION
incore.php
to 3.4.5 to trigger the upgrade script