ubc / iPeer

Peer Evaluation System
http://ipeer.ctlt.ubc.ca
Other
17 stars 18 forks source link

Roster update - search users with filter status Active #649

Open stemar opened 4 years ago

stemar commented 4 years ago

I do not believe that you or the LTI lib you are using are filtering out users by status. Based on the approach you are using, you should only be using members with a membership status of Active https://www.imsglobal.org/spec/lti-nrps/v2p0#membership-status

this also applies to removeRemainingUsersFromIpeerRoster and addRemainingUsersInIpeerRoster

As an alternative, (if I remember correctly) ipeer can set users to an inactive enrollment status so you could do as you currently do but set the user's enrollment status to active/inactive instead (ex in addUserToCourse)

_Originally posted by @andrew-gardener in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDExMTM4MDY5/pull_request_reviews/more_threads_