ubccpsc / classportal_deprecated

DEPRECATED: ClassPortal instance from 2017.
3 stars 5 forks source link

Team Size #14

Open rtholmes opened 7 years ago

rtholmes commented 7 years ago

I have manually created some teams of three with the current install. If you look you'll see a bunch of names in 'create team' that you will also see on the list above (see team 85, 86, 87). On the students page their team number also doesn't show up. Any ideas? I wonder if it's just iterating twice through each team somewhere instead of through all members?

rtholmes commented 7 years ago

This was my mistake entirely. If you add someone to a team you need to also set their hasTeam attribute to true.

mksarge commented 7 years ago

Team size is set in config.js under the property team_size. I just searched the project and found 2 places in the project that this value is used in a non-trivial way:

mksarge commented 7 years ago

More team_size design notes:

With the current design, it is not possible to create teams of various sizes. Specifically, you can't:

One simple-enough change that would allow variable team sizes, with an upper limit, is simply re-purpose team_size into max_team_size and allow the Create Team submission button to accept teams of

1 <= n <= max_team_size or 1 < n <= max_team_size.

@rtholmes Thoughts? Were you just testing the system by making those teams of three, or are they meant to be legitimate teams this semester?

rtholmes commented 7 years ago

I manually forced a few students into three-person to help even out lab sizes in the course and to reflect students who had withdrawn from the course. So while students were only allowed to select two-person teams, being able to specify n+1 on the admin view might have been helpful. This is certainly not a normal use case, but team changes late in the term tend to be tricky either way.