search

ubccpsc / classportal_deprecated

DEPRECATED: ClassPortal instance from 2017.
3 stars 5 forks source link

Code style #9

Open mksarge opened 8 years ago

mksarge commented 8 years ago

@rtholmes, what are your preferences for code style?

Right now I'm using my IDE (VS Code)'s auto-format function for both TS and JS/JSX, with default settings.

For linting, I've already imported TS lint into the project, and have been looking at ES lint for the client-side JS/JSX, but haven't had a chance to discuss it with you.

The reason I'm only asking now, is that my auto-formatter has not complained about anything you've committed in the past until yesterday's commits (specifically, the left-shifted indentation for everything in the async arrays; my IDE tries to right-shift the indents back to the way it was before). Not a big deal, but I thought I'd ask.

rtholmes commented 8 years ago

@mksarge, no particular preference. Webstorm just did the indentation on that; feel free to override. I did change the else structure manually though so } else { all occurred on one line.

mksarge commented 8 years ago

@rtholmes, I updated the project with ESLint, TSlint, and editorconfig files, and started refactoring some of the frontend code. But I think we can hold off integrating it until our test suite is a little more complete, so I pushed to the eslint branch for now.