Invalid grade sheets should be ignored, but a CSV-parsing flag is not working as expected.
Expected behaviour (required):
Instead of rejecting the file, the code proceeds with parsing. The test below should fail but is passing. We have tried the code with valid and invalid files and the results are the same.
Source code in question (required):
This is the block that parses the CSV, we think it should be rejecting the file immediately:
Current behaviour (required):
Invalid grade sheets should be ignored, but a CSV-parsing flag is not working as expected.
Expected behaviour (required):
Instead of rejecting the file, the code proceeds with parsing. The test below should fail but is passing. We have tried the code with valid and invalid files and the results are the same.
Source code in question (required):
This is the block that parses the CSV, we think it should be rejecting the file immediately:
https://github.com/ubccpsc310/classy/blob/5158ecad92e51269c01cdd67439a24dc5000439d/packages/portal/backend/src/server/common/CSVPrairieLearnParser.ts#L50-L59
Test code demonstrating the problem (required):
This test executes the parser with an invalid file, but it does not pass:
https://github.com/ubccpsc310/classy/blob/5158ecad92e51269c01cdd67439a24dc5000439d/packages/portal/backend/test/CSVPrairieLearnParserSpec.ts#L62-L74
Anything else (optional):
N/A