search

ubccr / coldfront

HPC Resource Allocation System
https://coldfront.readthedocs.io
GNU General Public License v3.0
96 stars 76 forks source link

Allocation Requests list: Incorrect text displayed on activate button #415

Closed dsajdak closed 1 year ago

dsajdak commented 2 years ago

Allocations pending activation are not displaying the correct text.

allocation_approval

These two allocations are both in the 'approved' status; however, the green button for one shows 'activate' and the other shows 'approve.' The one showing 'activate' has allocation attributes already assigned to it. The other one does not. If we click the 'approve' button, it will ask if you're sure you want to approve with no attributes set:

allocation_approval2

If you click 'yes' it changes the status to 'active' and sets the expiration date out one year. Which is the same thing that happens with the 'activate' button. The text for either scenario should be 'activate'

Task Tests:

  1. Sign into ColdFront
  2. Create multiple allocations and set yourself as a user
  3. Change the status of some of the allocations to something other than 'new' such as 'approved' and 'paid'
  4. Login as the sys admin and navigate to the 'Allocation requests' list
  5. Click on the details button of one of the allocations and add at least one allocation attribute but do not change the status.
  6. Go back to the 'allocation requests' list and see if the green button now shows 'activate' rather than 'approve'
  7. Click on the 'activate' button to change the status of that allocation to 'active' and confirm the expiration date is set one year from now.
  8. Click on the 'activate' button of the allocation with no attributes and ensure that you get prompted to activate it without setting attributes. Click 'yes' and verify the status has been change to 'active' and the expiration date set out one year.