ubccr / coldfront

HPC Resource Allocation System
https://coldfront.readthedocs.io
GNU General Public License v3.0
101 stars 80 forks source link

As an admin, I'd like PIs to agree to terms and conditions while requesting a resource allocation #420

Open knikolla opened 2 years ago

knikolla commented 2 years ago

For compliance reasons, there is a need to display and require a PI agree to a set of terms and conditions (may be in-line, or a hyperlink to a different location). These terms and conditions are specific to a Resource, with each Resource possibly having a different set of terms and conditions to agree to.

mdzik commented 2 years ago

Hello,

I think that you could set EULA as an resource attribute to get such behaviour. I dont remember attribute name but it was something 'simple'.

śr., 29 cze 2022, 19:10 użytkownik Kristi Nikolla @.***> napisał:

For compliance reasons, there is a need to display and require a PI agree to a set of terms and conditions (may be in-line, or a hyperlink to a different location). These terms and conditions are specific to a Resource, with each Resource possibly having a different set of terms and conditions to agree to.

— Reply to this email directly, view it on GitHub https://github.com/ubccr/coldfront/issues/420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3A5RZLLLCTPLVPWX6IBJTVRR7P3ANCNFSM52GPJ2QA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

knikolla commented 2 years ago

Thank you @mdzik,

Looks like it's the 'EULA' attribute. https://github.com/ubccr/coldfront/blob/4c10771f0f2c24ebf356a2818b5a4233525ee8a9/docs/pages/manual/resources/resources.md#resource-attributes

Software license resources may contain the 'EULA' attribute and the value should be the text of the license, a URL to register for a license or instructions for complying with the license restrictions

dsajdak commented 2 years ago

Thanks @mdzik! Yes, @knikolla this is what we use for requiring PIs to agree to license terms on behalf of their group. When they go to renew an allocation they will be presented with the EULA again. There is some improvement that can be made on this though so I'm going to leave the issue open. One is that the EULA attribute is on the resource and not seen when looking at the allocation detail page. This is something we should probably display on the allocation detail page. We may even want to provide a warning or reminder when adding new users to the allocation for a resource with a EULA.

mdzik commented 2 years ago

My pleasure:)

I think that users should be forced to accept it, at least for some cases - like 2 step signing to allocation?

sob., 2 lip 2022, 17:54 użytkownik Dori Sajdak @.***> napisał:

Thanks @mdzik https://github.com/mdzik! Yes, @knikolla https://github.com/knikolla this is what we use for requiring PIs to agree to license terms on behalf of their group. When they go to renew an allocation they will be presented with the EULA again. There is some improvement that can be made on this though so I'm going to leave the issue open. One is that the EULA attribute is on the resource and not seen when looking at the allocation detail page. This is something we should probably display on the allocation detail page. We may even want to provide a warning or reminder when adding new users to the allocation for a resource with a EULA.

— Reply to this email directly, view it on GitHub https://github.com/ubccr/coldfront/issues/420#issuecomment-1172919509, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3A5RZ4Q4MQVDPORQXIHULVSBQZTANCNFSM52GPJ2QA . You are receiving this because you were mentioned.Message ID: @.***>

dsajdak commented 1 year ago

The EULA attribute comes from the resource so it's not something the allocations users see except when requesting a new allocation or renewing the allocation. We'd like to add some enhancements to this so the users have more visibility to this.

To do:

dsajdak commented 1 year ago

We've removed out the more complex feature request (requiring users to agree to a EULA) to this issue (#542)