dsajdak
commented
1 year ago A few minor things to fix:
- A user (non-manager) on a project can't edit the project attributes so they should not see the edit button under the 'actions' column. It should be just like allocation attributes where that is not visible.
- 'Has usage' should not be a default on the default project attributes as 'Account Number' and 'Project ID' would not have usage.
- Recommend making 'Project ID' a text attribute. I anticipate some centers would use alphanumeric data here. Some may use that for 'Account number' too but they could change that if desired. This would just give 2 different examples of project attribute types.
- Project attribute marked 'is private' can not be viewed by managers on the project but a manager could add a new attribute value to the project for a private attribute. This will be confusing for users. We should not allow a manager to add an attribute if it has the 'is private' box checked.
- Managers are able to delete attributes that are marked 'is private.' Though they can't see them on the project detail page, when they click 'Delete' on the project attributes section, the list displayed there shows all attributes including those marked 'is private.' We should not display these private attributes in the delete list.
- Update the informational hover for the 'Role' column header in the 'Project Detail' page for users on a project to read: "Manager role grants user access to add & remove users, attributes, publications, grants, & research output to the project and request/renew allocations."
aebruno
Draft PR that is built off PR (#399) created by @RyanChang0369.
Issues that need to be addressed with this PR are commented in (#399). Additional changes are possible as work continues on this feature.