Closed knikolla closed 1 year ago
There is an allocation_disable signal, but it is only sent for the Denied status. https://github.com/ubccr/coldfront/blob/68ba4b62ea5e47cf2295dede1f3df13868ec4788/coldfront/core/allocation/views.py#L251
allocation_disable
Denied
It should at least also be sent for the Revoked status, and perhaps some other relevant status.
Revoked
The motivation is that it does seem a bit weird to "deny" an allocation that already exists, rather than "revoking" it.
There is an
allocation_disablesignal, but it is only sent for theDeniedstatus. https://github.com/ubccr/coldfront/blob/68ba4b62ea5e47cf2295dede1f3df13868ec4788/coldfront/core/allocation/views.py#L251It should at least also be sent for the
Revokedstatus, and perhaps some other relevant status.The motivation is that it does seem a bit weird to "deny" an allocation that already exists, rather than "revoking" it.