ubccr / coldfront

HPC Resource Allocation System
https://coldfront.readthedocs.io
GNU General Public License v3.0
96 stars 76 forks source link

Ability to enable/ disable grant, publication, and research output functionality added #524

Open rg663 opened 1 year ago

rg663 commented 1 year ago

Resolves issue #507 — users can now toggle whether or not they would like grant, publication, and research output functionality by setting the following environment variables:

To avoid conflicts while reenabling, these apps are installed by default, but if a user sets the environment variable to False for any of the above, it removes all functionality from the frontend.

dsajdak commented 1 year ago

This is looking really good. Providing the option to disable/enable each of these pieces separately is great. Let's add a few more pieces of logic to this in other areas of ColdFront:

  1. On the project detail page at the top are buttons for Add User and Add Publication/Grant/Research Output. If all three of these are disabled, let's remove this section completely because all that is left is Add User. If any of them are enabled, we can display the buttons.
  2. In the Project Review logic, we force the PI to provide a justification if they have not updated their publications OR grants in the last 365 days. If these two are both disabled, let's remove this requirement for a justification. If one or the other is enabled, we can leave the requirement. There is a checkbox asking the PI to confirm the project information is up-to-date. This should be left visible regardless of what options are enabled/disabled.
rg663 commented 1 year ago

Fixed! @dsajdak