ubccr / coldfront

HPC Resource Allocation System
https://coldfront.readthedocs.io
GNU General Public License v3.0
96 stars 76 forks source link

Bug: Allocations in "pending renewal" status not treated as active #610

Closed dsajdak closed 3 weeks ago

dsajdak commented 3 weeks ago

What happened?

An allocation with a "pending renewal" status should still be treated as active until or unless the allocation is expired. If not, when ColdFront plug-ins are used to update accounts like the FreeIPA plugin or the Slurm plugin, accounts are incorrectly updated. For example, users on the allocation are removed from FreeIPA groups because the plugin doesn't think that allocation is active.

Version

None

Component

Allocations

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Tasks/ user tests when bug is fixed

dsajdak commented 3 weeks ago

Now I can't reproduce and after reviewing this commit it does appear to fix the problem. Going to close this issue but if anyone else can reproduce, feel free to comment on it and we'll re-open it.