search

ubccr / mokey

FreeIPA self-service account management portal
BSD 3-Clause "New" or "Revised" License
194 stars 46 forks source link

Support TLS SMTP #27

Closed g5pw closed 5 years ago

g5pw commented 5 years ago

In 449d946e983bb3dd8231185d2f499d7df9ede0fa support for SMTP STARTTLS was added. Support for TLS SMTP (all encrypted) is the only one missing 😄

I'll brush up my (lacking) Go skills and prepare a small PR since I made it work already for our installation. I propose we deprecate the smtp_starttls boolean option and use smtp_tls with three values, off, on, starttls. Would that be acceptable?

aebruno commented 5 years ago

@g5pw Yes this sounds great. Would be happy to review a PR with this in place. Thanks!

g5pw commented 5 years ago

As promised, here is the v1 @aebruno. Bear in mind that go is pretty new for me :)

g5pw commented 5 years ago

Uh-oh, something is not right, please hold on this for a bit while I test some more...

g5pw commented 5 years ago

Alright, it should be good now.

g5pw commented 5 years ago

Thanks for the review @aebruno, I'll push the changes shortly. Would you prefer a squashed merge for this PR or should I reorder the commits a bit?

aebruno commented 5 years ago

squashed would be great. Thanks.

Thanks for the review @aebruno, I'll push the changes shortly. Would you prefer a squashed merge for this PR or should I reorder the commits a bit?

g5pw commented 5 years ago

Alright, squashed some commits, rebased on the new master, integrated the requested changes, this should be good to go if it's fine by you.