Initial implementation of change expired password

ubccr / mokey

FreeIPA self-service account management portal

BSD 3-Clause "New" or "Revised" License

194 stars 46 forks source link

Initial implementation of change expired password #85

Closed xx4h closed 3 years ago

xx4h commented 3 years ago

detect correct but expired password in tryAuth
redirect to ChangeGet if correct but expired password has been detected in LoginPost
Added corresponding ChangePost for ChangeGet to actually change the password
Added new template for ChangeGet/ChangePost to templates
Added new routes for ChangeGet/ChangePost to handlers
Added new setPassword functions which explicitly can be used before authentication, and which of course only works if the password is correct (only expired)

ref #84

aebruno commented 3 years ago

Now that ubccr/goipa#8 is merged (released goipa v0.0.5), can you update go modules in this PR. So something like this should do the trick:

$ go get github.com/ubccr/goipa@v0.0.5

xx4h commented 3 years ago

Should we remove the refrences for goipa@v0.0.4 from go.sum?

xx4h commented 3 years ago

Should we remove the refrences for goipa@v0.0.4 from go.sum?

i think so, updated again.

aebruno commented 3 years ago

Should we remove the refrences for goipa@v0.0.4 from go.sum?

Yes, go get should take care of all that for you.

xx4h commented 3 years ago

Should we remove the refrences for goipa@v0.0.4 from go.sum?

Yes, go get should take care of all that for you.

most of it, yes. but i had to remove the old refrences (for v0.0.4) by my self.

aebruno commented 3 years ago

The only suggestion I'd make for a nicer user experience is to issue a 'success' message after the password change is made. Right now it just redirects to the login window and the user doesn't know for sure that the password change worked.

@xx4h Off the top of my head, this should be doable using a flash message. Something like sess.AddFlash("Password change successful") and then just making sure we display those flash messages on the login page. Need to add the {{ range $m := .flashes }} to the template.

xx4h commented 3 years ago

Thanks for adding the extra message on the password change success. This looks great!

Happy to see you liking it :) you're welcome

aebruno commented 3 years ago

@xx4h Thanks for all your work on this!

xx4h commented 3 years ago

@xx4h Thanks for all your work on this!

You're welcome. Thanks for all your feedback and ideas too!