ubclaunchpad / LP-website

UBC Launch Pad knowledge base
https://www.ubclaunchpad.com
8 stars 5 forks source link

bug: opening links in new tab from homepage shows HTML #180

Closed engineereng closed 3 years ago

engineereng commented 3 years ago

Description:

Opening the following links from https://docs.ubclaunchpad.com/ in a different browser tab results in the viewer seeing the raw HTML:

Found on Google Chrome Version 85.0.4183.121 (Official Build) (64-bit).

Steps to replicate this issue:

  1. Right click either of the links mentioned above and select new tab

right click

  1. Click "new tab". The page will redirect to the .HTML file. new tab

Recommended fixes: Link to https://docs.ubclaunchpad.com/introduction instead of https://docs.ubclaunchpad.com/introduction.html and https://docs.ubclaunchpad.com/CONTRIBUTING instead of https://docs.ubclaunchpad.com/CONTRIBUTING.html

bobheadxi commented 3 years ago

Unfortunately, this might be a VuePress limitation, since in markdown we link directly to markdown files and - though I swear we have a plugin to drop the trailing .html extension:

https://github.com/ubclaunchpad/docs/blob/master/.vuepress/config.js#L137-L138

Aside, and probably not relevant, but this is enabled on the Netlify side with this config: https://github.com/ubclaunchpad/docs/blob/master/netlify.toml#L7-L32

bobheadxi commented 3 years ago

I managed to include a fix for this in #197