Course Crud endpoints - Githubissues

ubclaunchpad / forum

ForumAI combines AI capabilities with structured academic forums, enabling students and faculty to collaborate in a controlled environment where AI assists learning while maintaining academic integrity.

MIT License

12 stars 0 forks source link

Course Crud endpoints #97

Closed olichengus closed 1 day ago

olichengus commented 3 days ago

Proposed Changes

Finished implementations of the course endpoints in issue.
Passed preliminary tests, but can improve error handling and further testing. PR just to unblock others.

armintalaie commented 3 days ago

also check the readme on how to run the formatter -> let's have all checks pass :)

olichengus commented 3 days ago

Hi. thanks for the work. i will review it in more detail but some things:

use some sort of validation library (i think i saw shreyas use pydantic)

Past migrations shouldn't be altered (as if they are logs). if you are making changes, edits, dropping, anything, make a new .sql file please. otherwise it might fail on some build envs.

I am using pydantic to create request models, should I do the same for the response models or run any other verification?