Add techlead functionality, minor cleanup on README and docs

bobheadxi commented 6 years ago

Closes #56, closes #63 , closes #78

Add is_techlead field and associated functions, commands, etc. etc.
Reorganize README (architecture first, add godoc badge, etc.)
Update missing docstring, rename CorePlugin to RocketPlugin - VS Code Golang plugin was complaining a lot

This is best reviewed commit-by-commit rather than as a whole

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 11

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
core/add_admin.go	0	1	0.0%
core/add_team.go	0	1	0.0%
core/view_user.go	0	1	0.0%
core/add_user.go	0	1	0.0%
core/admins.go	0	1	0.0%
core/view_team.go	0	1	0.0%
core/edit_team.go	0	1	0.0%
core/teams.go	0	1	0.0%
core/refresh.go	0	1	0.0%
core/remove_admin.go	0	1	0.0%
<!--	Total:	29	75	38.67%	-->

coveralls commented 6 years ago

67 of 147 (45.58%) changed or added relevant lines in 18 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.6%) to 43.056%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
plugins/core/view_user.go	0	1	0.0%
plugins/core/view_team.go	0	1	0.0%
plugins/core/teams.go	0	1	0.0%
plugins/core/admins.go	0	1	0.0%
plugins/core/remove_user.go	0	1	0.0%
plugins/core/refresh.go	0	1	0.0%
plugins/core/edit_user.go	0	1	0.0%
plugins/core/remove_team.go	0	1	0.0%
cmd/cmd.go	3	5	60.0%
plugins/core/add_team.go	1	4	25.0%
<!--	Total:	67	147	45.58%	-->

Files with Coverage Reduction	New Missed Lines	%
cmd/cmd.go	1	94.87%
<!--	Total:	1		-->

bfbachmann commented 6 years ago

I'd also change set-admin and set-techlead to toggle-admin and toggle-techlead to make them less confusing.