ubclaunchpad / rocket2

🚀 The official UBC Launch Pad Slack bot and team management platform
https://rocket2.readthedocs.io
Other
18 stars 6 forks source link

feat: grant team lead maintainer permissions on team create #595

Closed no-or closed 4 years ago

no-or commented 4 years ago

team: grant team lead maintainer permissions on github team

Closes #547

Details

Before the change: cmd: /rocket team create <team-name> --lead noor result: noor is added to lead but not as a maintainer of the team

After the change: cmd: /rocket team create <team-name> --lead noor result: noor is added to lead who is also a maintainer of the team

codecov[bot] commented 4 years ago

Codecov Report

Merging #595 (142d379) into master (eb95e33) will decrease coverage by 0.10%. The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   93.09%   92.98%   -0.11%     
==========================================
  Files          42       42              
  Lines        2420     2425       +5     
  Branches      323      323              
==========================================
+ Hits         2253     2255       +2     
- Misses        109      112       +3     
  Partials       58       58              
Impacted Files Coverage Δ
interface/github.py 94.35% <40.00%> (-2.29%) :arrow_down:
app/controller/command/commands/team.py 86.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb95e33...142d379. Read the comment docs.

chuck-sys commented 4 years ago

(Later task): make it so that leads themselves don't have to specify themselves in --leads. I'd be pretty annoyed if I have to do that every time without tab-complete.