search

ubclaunchpad / ubclaunchpad.com

✨ The official UBC Launch Pad website - https://ubclaunchpad.com
https://medium.com/ubc-launch-pad-software-engineering-blog/introducing-the-new-launch-pad-website-42175181d644
MIT License
10 stars 2 forks source link

make modal link path-based rather than query-based #172

Open bobheadxi opened 4 years ago

bobheadxi commented 4 years ago

The initial implementation introduced in #94 uses query strings:

https://ubclaunchpad.com?project=physio+space#teams

Ideally this would be path-based, such that a link would look like:

https://ubclaunchpad.com/project/physio+space#teams

This change would mostly be for the sake of analytics, since paths are easier to sort through, and it just looks nicer. It also wouldn't cause too many issues because analytics indicate that hardly anybody uses the modal link feature at the moment, but we can maintain compatability with a redirect rule

bobheadxi commented 4 years ago

Update: on the analytics side I am using a hack to put the URL params into fathom trackPageview requests as if they were part of the normal path. Long-term I still think a path-based implementation would be a cleaner solution, however