ubclaunchpad / ubclaunchpad.github.io-old

🍗 (formerly) UBC Launch Pad's official website - superseded by https://github.com/ubclaunchpad/ubclaunchpad.com
2 stars 0 forks source link

Render Markdown emoji everywhere #57

Closed bobheadxi closed 6 years ago

bobheadxi commented 6 years ago

This is what disappointment looks like

image
bfbachmann commented 6 years ago

This is a fairly non-trivial task, and I'm not really sure it's worth it. I would actually like to avoid putting emojis in team names all-together, because it makes editing and updating teams by name through Rocket error-prone. In fact, it actually makes it near impossible for most unicode emojis that Slack supports because Slack auto-corrects unicode emojis it their :emoji-name: equivalent.

bobheadxi commented 6 years ago

There are libraries that support it - I have emoji rendering in my jekyll blog

bfbachmann commented 6 years ago

I guess what I'm saying it that the work required is relatively high for it's payoff. We'd have to add new option parsing rules to look for things that represent Slack emojis depending on command and context. Then we'd have to translate that plain-text into the unicode equivalent (for which there may not be a mapping, because Slack supports custom emojis), then insert into the DB. We'd also have to to the same when querying the DB.

bobheadxi commented 6 years ago

Slack emojis translate are the same as normal Markdown emoji - for example, :cloud: is ☁️ here in GitHub too. Any library that can handle Markdown emoji will work here. For example, it could see the markdown :cloud: and render the ☁️ appropriately. jemoji is one such plugin for jekyll - all we need to do is see if one exists and use it

bfbachmann commented 6 years ago

True, but that's not the case on our website, and my point about it being more work than it's worth still stands.

bfbachmann commented 6 years ago

I'm open to us building this feature, but it needs to be done properly and there are much more useful things we should do first.