ubeacsec / Silverdog

An audio firewall for Chrome!
http://ubeacsec.org
Apache License 2.0
69 stars 7 forks source link

Wrong BiquadFilter type #14

Open ppseprus opened 7 years ago

ppseprus commented 7 years ago

The default BiquadFitler type is highshelf. The documentation says "Frequencies higher than the frequency get a boost or an attenuation; frequencies lower than it are unchanged.", but I think a lowpass would be better, considering its description "Standard second-order resonant lowpass filter with 12dB/octave rolloff. Frequencies below the cutoff pass through; frequencies above it are attenuated.". I might not understand these well enough, but lowpass better.

mavroudisv commented 7 years ago

During the development phase we tried lots of different filter combinations, and indeed low pass was our first choice.

However, it didn't work as expected and we got better performance using the highshelf. However, if you decide to test it and you get better results let me know, and we can always switch..