search

uber-archive / cherami-server

Distributed, scalable, durable, and highly available message queue system. This project is deprecated and not maintained.
https://eng.uber.com/cherami/
MIT License
1.42k stars 102 forks source link

upgrade ringpop to latest #283

Closed datoug closed 7 years ago

datoug commented 7 years ago

This is to address https://github.com/uber/cherami-server/issues/225

There was a breaking ringpop change documented in https://github.com/uber/ringpop-go/blob/master/CHANGES.md:

Breaking change to the identity-option

Prior to ringpop v0.8.0 the address was used as the identity of a member. Starting with version v0.8.0, it's possible to configure a separate identity. As a result, the behaviour of the Identity and IdentityResolverFunc has been changed. The Identity option now configures the identity of a member and will return an error when it matches an ip:port; services that were using Identity or IdentityResolverFunc should now use the Address and AddressResolverFunc options. You could use the following gofmt snippets to easily refactor:

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 67.227% when pulling 4801950b6f9a3f0e82b9d914502784b62a41faec on rp into 213124ab707a3ab192b9029dafa68b510912f6a9 on master.