search

uber-archive / cherami-server

Distributed, scalable, durable, and highly available message queue system. This project is deprecated and not maintained.
https://eng.uber.com/cherami/
MIT License
1.42k stars 102 forks source link

Change some kafka related variable names to fix lint error #308

Closed kobeyang closed 6 years ago

kobeyang commented 6 years ago

To fix: ➜ cherami-server git:(fix_lint) > make lint ./services/outputhost/kafkaStream.go:46:2: don't use leading k in Go names; struct field kConverter should be converter ./services/outputhost/kafkaStream.go:51:1: comment on exported type KafkaMessageConverterConfig should be of the form "KafkaMessageConverterConfig ..." (with optional leading article) Found 2 lint suggestions; failing. ./services/outputhost/outputhost.go:95:3: don't use leading k in Go names; struct field kStreamFactory should be streamFactory Found 1 lint suggestions; failing. make: *** [lint] Error 1

kirg commented 6 years ago

I thought @mmchen already fixed this; see #302.