Closed kirg closed 6 years ago
Can we separate refactoring from the logic change? This logic is rather important to get right and reviewed throughly. Suggestion:
PR 1:
PR 2:
PR 3: rest
@thuningxu okay; will try and split up this PR.
I have created two new PRs:
I am going to leave this PR open for now. After the above two have been landed, I will remove those changes from this PR. leaving this PR to address the following, more minor issues:
closing out this PR, since there's too many conflicts with master, etc. will recreate PR with the rest of the changes ..