Sequence number should be outside of message converter

uber-archive / cherami-server

Distributed, scalable, durable, and highly available message queue system. This project is deprecated and not maintained.

https://eng.uber.com/cherami/

MIT License

1.42k stars 102 forks source link

Sequence number should be outside of message converter #327

Closed thuningxu closed 6 years ago

coveralls commented 6 years ago

Coverage decreased (-0.09%) to 66.54% when pulling 5df6bf3d89f0ccb9bde866d207e171fd5d511d9e on kafka2 into 65a1bb1404b63ce07025a2a3f6d34187fddce030 on master.

kirg commented 6 years ago

Good catch. Minor comment, otherwise looks good to me.

coveralls commented 6 years ago

Coverage increased (+0.1%) to 66.76% when pulling 062c357deefd534fb0ea0c8062f8942b6b3932ed on kafka2 into 65a1bb1404b63ce07025a2a3f6d34187fddce030 on master.